feat: about migrate to cmp #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niyajali @biplab1 @HekmatullahAmin Please let me know if any changes or improvements are needed. If everything looks good, please merge it. |
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutItem.kt
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutScreen.kt
Outdated
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutViewModel.kt
Outdated
Show resolved
Hide resolved
revanthkumarJ
suggested changes
May 19, 2025
There was a problem hiding this comment.
@kapmaurya like as @HekmatullahAmin told we don't need a viewmodel here.
use an array instead . Refer mifos mobile and do the things exactly same just needed to change images and string values accordingly
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutItem.kt
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutScreen.kt
Outdated
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutScreen.kt
Outdated
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutScreen.kt
Outdated
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutScreen.kt
Outdated
Show resolved
Hide resolved
|
@kapmaurya and don't resolve the conversation until it is done |
biplab1
reviewed
May 19, 2025
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutViewModel.kt
Outdated
Show resolved
Hide resolved
feature/about/src/commonMain/kotlin/com/mifos/feature/about/AboutViewModel.kt
Outdated
Show resolved
Hide resolved
|
@kapmaurya lets focus on merge this one first. |
|
@kapmaurya Any update? |
# Conflicts: # build-logic/convention/src/main/kotlin/CMPFeatureConventionPlugin.kt
|
niyajali
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes -[ Jira-#Issue_Number](https://mifosforge.jira.com/browse/MIFOSAC-412)
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.